router-tests/telemetry/attribute_processor_test.go (1)

240-250: Stabilize this flaky assertion by separating trigger from polling.

Line 241 currently sends a new request on every Eventually poll, and line 250 depends on logs[0] ordering. This can still be nondeterministic. Send one request, then poll only for the expected message across all matching log entries.

Suggested refactor

 	}, func(t *testing.T, xEnv *testenv.Environment) {
-		require.Eventually(t, func() bool {
-			xEnv.MakeGraphQLRequestOK(testenv.GraphQLRequest{
-				Query: `query { employees { id } }`,
-			})
-			logs := xEnv.Observer().FilterMessageSnippet("sanitize_utf8").All()
-			return len(logs) > 0
-		}, 10*time.Second, 500*time.Millisecond)
-
-		logs := xEnv.Observer().FilterMessageSnippet("sanitize_utf8").All()
-		require.NotEmpty(t, logs)
-		require.Equal(t, "otel error: traces export: string field contains invalid UTF-8: Enable 'telemetry.tracing.sanitize_utf8.enabled' in your config to sanitize invalid UTF-8 attributes.", logs[0].Message)
+		expected := "otel error: traces export: string field contains invalid UTF-8: Enable 'telemetry.tracing.sanitize_utf8.enabled' in your config to sanitize invalid UTF-8 attributes."
+
+		xEnv.MakeGraphQLRequestOK(testenv.GraphQLRequest{
+			Query: `query { employees { id } }`,
+		})
+
+		require.Eventually(t, func() bool {
+			logs := xEnv.Observer().FilterMessageSnippet("sanitize_utf8").All()
+			for _, entry := range logs {
+				if entry.Message == expected {
+					return true
+				}
+			}
+			return false
+		}, 10*time.Second, 500*time.Millisecond)
 	})

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@router-tests/telemetry/attribute_processor_test.go` around lines 240 - 250,
The test currently re-sends the GraphQL request on every Eventually poll and
then asserts logs[0], which causes flakiness; instead call
xEnv.MakeGraphQLRequestOK(...) once before polling, then use require.Eventually
to repeatedly read xEnv.Observer().FilterMessageSnippet("sanitize_utf8").All()
and check that any entry's Message equals the expected string (or that the slice
contains the expected message), finally assert the logs slice is not empty and
contains the expected message — update references in the test to
xEnv.MakeGraphQLRequestOK, xEnv.Observer().FilterMessageSnippet(...).All(), and
the expected message string so ordering of logs[0] is not relied upon.

router-tests/telemetry/attribute_processor_test.go (1)

241-248: ⚠️ Potential issue | 🟠 Major

Avoid order-dependent assertion on logs[0] in a flaky-test fix path.

Line 248 assumes deterministic ordering of matching logs. If multiple sanitize_utf8 logs exist, this can still fail intermittently.

💡 Suggested stabilization

-			require.Eventually(t, func() bool {
-				logs := xEnv.Observer().FilterMessageSnippet("sanitize_utf8").All()
-				return len(logs) > 0
-			}, 10*time.Second, 500*time.Millisecond)
-
-			logs := xEnv.Observer().FilterMessageSnippet("sanitize_utf8").All()
-			require.NotEmpty(t, logs)
-			require.Equal(t, "otel error: traces export: string field contains invalid UTF-8: Enable 'telemetry.tracing.sanitize_utf8.enabled' in your config to sanitize invalid UTF-8 attributes.", logs[0].Message)
+			expected := "otel error: traces export: string field contains invalid UTF-8: Enable 'telemetry.tracing.sanitize_utf8.enabled' in your config to sanitize invalid UTF-8 attributes."
+			require.Eventually(t, func() bool {
+				logs := xEnv.Observer().FilterMessageSnippet("sanitize_utf8").All()
+				for _, log := range logs {
+					if log.Message == expected {
+						return true
+					}
+				}
+				return false
+			}, 10*time.Second, 500*time.Millisecond)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@router-tests/telemetry/attribute_processor_test.go` around lines 241 - 248,
The test is brittle because it asserts logs[0].Message equals the expected
string which fails if multiple matching "sanitize_utf8" entries appear; update
the assertion in attribute_processor_test.go to be order-independent by checking
that at least one entry in
xEnv.Observer().FilterMessageSnippet("sanitize_utf8").All() has Message equal to
the expected text (or assert the slice of messages contains the expected string)
instead of directly indexing logs[0]; locate the require.NotEmpty(t, logs) and
replace the require.Equal on logs[0].Message with a search/contains assertion
over the messages returned by FilterMessageSnippet.